Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: enable flush rate limiter of collection level #33837

Merged
merged 1 commit into from
Jun 24, 2024
Merged

enhance: enable flush rate limiter of collection level #33837

merged 1 commit into from
Jun 24, 2024

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 13, 2024
@jaime0815 jaime0815 force-pushed the enable-flush-ratelimter-of-collection-level branch from 8c9ffb2 to 0d87b05 Compare June 14, 2024 02:41
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jun 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815 jaime0815 force-pushed the enable-flush-ratelimter-of-collection-level branch 2 times, most recently from 7f97a5f to c48172a Compare June 14, 2024 05:38
@jaime0815 jaime0815 mentioned this pull request Jun 14, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (5be9929) to head (dbad4ef).
Report is 30 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33837      +/-   ##
==========================================
- Coverage   80.97%   80.96%   -0.02%     
==========================================
  Files        1064     1064              
  Lines      136541   136541              
==========================================
- Hits       110566   110548      -18     
- Misses      21769    21772       +3     
- Partials     4206     4221      +15
Files Coverage Δ
pkg/util/paramtable/quota_param.go 79.71% <100.00%> (-0.09%) ⬇️

... and 30 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Jun 14, 2024
@jaime0815
enhance: enable flush rate limiter of collection level (#33864)
fd1c7b1 
pr: #33837

Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

6 similar comments
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
enhance: enable flush rate limiter of collection level
dbad4ef 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 force-pushed the enable-flush-ratelimter-of-collection-level branch from c48172a to dbad4ef Compare June 20, 2024 07:36
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 20, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d08cb88 into milvus-io:master Jun 24, 2024
15 checks passed
@jaime0815 jaime0815 deleted the enable-flush-ratelimter-of-collection-level branch June 24, 2024 03:23
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@jaime0815 @yellow-shine
enhance: enable flush rate limiter of collection level (milvus-io#33837)
4c31526 
Signed-off-by: jaime <yun.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaime0815 @czs007 @sre-ci-robot